Remove non-prod schedule variables #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed conditional logic for non-prod scheduling and related variables to streamline environment management. All schedules now use uniform variables regardless of environment, reducing complexity and potential errors.
adampie
changed the title
There was a problem hiding this comment.
I agree that we need to take the references to local.env out of the module, however we also need to record these variations between prod and nonprod environments so that appropriate configurations and / or conditionals can be included in the code which calls the module.
I'd suggest starting an examples folder - which is in any case required to be compliant with the Terraform registry - and include two examples, one the default which I'd suggest should be nonprod and then another example passing in the variables for prod.
The default values should therefore be the nonprod ones, as that's more straightforward for people to start with.
Added HashiCorp providers (aws, archive, null, random) configurations to nonprod, prod, and organizations terraform files. Updated module configurations for domain_protect with scan and update schedules. Set IAM role for domain_protect in organizations example and changed default value of takeover variable to false.
nitrocode
reviewed
Aug 21, 2024
nitrocode
reviewed
Aug 21, 2024
nitrocode
reviewed
Aug 21, 2024
nitrocode
reviewed
Aug 21, 2024
Signed-off-by: nitrocode <[email protected]>
nitrocode
force-pushed
the
remove-env-specific-code
branch
from
9cd584b to
f9585e0
Compare
Signed-off-by: nitrocode <[email protected]>
Signed-off-by: nitrocode <[email protected]>
nitrocode
reviewed
Aug 23, 2024
Signed-off-by: nitrocode <[email protected]>
nitrocode
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First MR switching multi-env schedule logic and variables into a single environment/variable.