Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consume lambda module #178

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

fzipi
Copy link
Contributor

@fzipi fzipi commented Jan 5, 2025

what

  • consume lambda module

why

  • simplify deployment

Todo

Still need to port:

  • lambda-accounts
  • lambda-cloudflare
  • lambda-resources
  • lambda-scan
  • lambda-scan-ips
  • lambda-slack
  • lambda-stats
  • lambda-takeover

references

Signed-off-by: Felipe Zipitria <[email protected]>
modules/lambda/outputs.tf Outdated Show resolved Hide resolved
modules/lambda/outputs.tf Outdated Show resolved Hide resolved
modules/lambda/outputs.tf Outdated Show resolved Hide resolved
modules/lambda/locals.tf Outdated Show resolved Hide resolved
modules/lambda/locals.tf Outdated Show resolved Hide resolved
@fzipi
Copy link
Contributor Author

fzipi commented Jan 6, 2025

While code looks reasonable, this one got really big really quick. I don't think it will be a reasonable approach to merge it. There is also a loop somewhere in the definitions.

I'm gonna save the changes and start with 1 (one) lambda function instead. We can at least validate the idea and see what's next.

What do we think about the locals approach for configuring lambdas? I find it very useful because it allows the same configuration without using module variables, simplifying deployments and rapid prototyping.

main.tf Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use open source modules for lambdas
3 participants