-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: consume lambda module #178
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Felipe Zipitria <[email protected]>
…cy-update Update deploy IAM policy for latest Terraform
…n-versions Check Python versions match
Signed-off-by: Felipe Zipitria <[email protected]>
…e-regex-module chore: replace regex with re
Upgrade to Python 3.12
Co-authored-by: RB <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
While code looks reasonable, this one got really big really quick. I don't think it will be a reasonable approach to merge it. There is also a loop somewhere in the definitions. I'm gonna save the changes and start with 1 (one) lambda function instead. We can at least validate the idea and see what's next. What do we think about the locals approach for configuring lambdas? I find it very useful because it allows the same configuration without using module variables, simplifying deployments and rapid prototyping. |
Co-authored-by: RB <[email protected]>
what
why
Todo
Still need to port:
references