-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bicep and CI workflow #3
base: main
Are you sure you want to change the base?
Conversation
if you can have a look @dolevshor 😉 |
That's great! @jbpaux |
Hi @jbpaux, |
Hi, |
Add quotes to file names update bicep action to latest Bump checkout GH Action version
@dolevshor I have re-rebased to include your latest changes. Feel free to merge it when you want |
Hi @dolevshor, Therefore, I´ve saw within this MS AZ public workbook "Azure | Home | Advisor | Workbooks | Gallery Cost | Optimization (Preview)" that it is possible to customize it, so looking into "advisorresources" tables under the following path "HOME>AZURE RESOURCE GRAPH EXPLORER>TABLE>advisorresources" url: "https://learn.microsoft.com/en-us/azure/cost-management-billing/finops/cost-optimization-workbook"), I´ve found these properties that I think will be useful to include it just to provide more inventory tracking and cost granularity view, to show to each Engineering Team what are the Acumulated Costs Impact of each idle resources and takes asap responsability on its optimizations. I´m not a AZ technical expert, just a FinOps practitioner, so these are the following properties that I beleive from my point of view could be nice to include it on your Workbook: Tables:
Fyi, I´m not a native english speaker, so apologize for any grammatical mistake and I hopes that this provide more value to this workbook. |
Hi,
I love your workbook.
In order to simplify the evolution of your workbook I suggest the following:
Since the Bicep Azure Action is not compatible with spaces in the file names I took the liberty of removing them (and I did a PR to the action to handle that in the future)