Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 fixes #4360

Merged
merged 18 commits into from
Dec 2, 2024
Merged

PHP 8.4 fixes #4360

merged 18 commits into from
Dec 2, 2024

Conversation

splitbrain
Copy link
Collaborator

This addresses a first few warnings on PHP 8.4. Many others are caused by 3rd party libraries which will hopefully be addressed soon.

splitbrain and others added 8 commits November 22, 2024 16:54
This removes code that has been marked as deprecated before 2020.
PHP 8.4 will throw a warning where type hints without a ?prefix are used
and nullable parameters can be passed.

I'm not sure if I found all occurances, but we still rarely use type
hints, so it might not be many indeed.
The use of trigger_error with a E_USER_ERROR is deprecated in PHP 8.4
Remove check for deprecated E_STRICT
replace deprecated utf8_encode #4354
This should be the last version supporting php 7.4
@splitbrain
Copy link
Collaborator Author

PHP-IXR fix sent upstream: kissifrot/php-ixr#12

@splitbrain
Copy link
Collaborator Author

splitbrain commented Nov 25, 2024

The only remaining issue is in PHP-DOMWrapper (which is a dev dependency only). We're still running version 2, Version 3 requires PHP 8.0. Currently this would be the only reason to upgrade our minimum requirements. I think I would like to do one last 7.4 release before updating.

So I think this is ready to be merged. Unless someone identifies any issues, I will do so in a couple of days.

@splitbrain splitbrain added the ToDo: QuickMerge This PR is either trivial or has not received any feedback in a while and thus should soon be merged label Nov 25, 2024
@splitbrain splitbrain added PHP Version Tasks about making DokuWiki compatible with new PHP releases dependencies Pull requests that update a dependency file labels Nov 27, 2024
@Espionage724
Copy link

The php84 branch seemingly works great so far!

I'm on FreeBSD 14.2 with php84. DokuWiki from master branch had warnings and broken elements on the install page, but php84 branch renders things fine.

My instance is here. I switched from Fedora Server 41 with master branch, did php84 branch on FreeBSD, and restored data/pages data/meta data/media data/media_meta data/attic data/media_attic conf folders.

@splitbrain splitbrain merged commit 8be857f into master Dec 2, 2024
16 checks passed
@splitbrain splitbrain deleted the php84 branch December 2, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file PHP Version Tasks about making DokuWiki compatible with new PHP releases ToDo: QuickMerge This PR is either trivial or has not received any feedback in a while and thus should soon be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants