-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.4 fixes #4360
PHP 8.4 fixes #4360
Conversation
This removes code that has been marked as deprecated before 2020.
PHP 8.4 will throw a warning where type hints without a ?prefix are used and nullable parameters can be passed. I'm not sure if I found all occurances, but we still rarely use type hints, so it might not be many indeed.
The use of trigger_error with a E_USER_ERROR is deprecated in PHP 8.4
Remove check for deprecated E_STRICT
replace deprecated utf8_encode #4354
This should be the last version supporting php 7.4
This is needed since PHP 8.4
PHP-IXR fix sent upstream: kissifrot/php-ixr#12 |
The only remaining issue is in PHP-DOMWrapper (which is a dev dependency only). We're still running version 2, Version 3 requires PHP 8.0. Currently this would be the only reason to upgrade our minimum requirements. I think I would like to do one last 7.4 release before updating. So I think this is ready to be merged. Unless someone identifies any issues, I will do so in a couple of days. |
The I'm on FreeBSD 14.2 with My instance is here. I switched from Fedora Server 41 with |
This addresses a first few warnings on PHP 8.4. Many others are caused by 3rd party libraries which will hopefully be addressed soon.