Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A collection of tutorial text fixes #297

Merged
merged 2 commits into from
Oct 23, 2017
Merged

Conversation

umaar
Copy link
Member

@umaar umaar commented Oct 23, 2017

#244 Feedback 1
#270 Feedback 1
#258 Feedback 1
#251 Feedback 3
#251 Feedback 4
#250 Feedback 2
#295 Feedback 1
#295 Feedback 5
#294 Feedback 3
#294 Feedback 9
#294 Feedback 12
#294 Feedback 13
#293 Feedback 1
#293 Feedback 2
#293 Feedback 14
#293 Feedback 15
#291 Feedback 1
#291 Feedback 2
#291 Feedback 3
#291 Feedback 5
#291 Feedback 6
#291 Feedback 8
#291 Feedback 16
#289 Feedback 6

Resolves #273
Resolves #274
Resolves #282
Resolves #283
Resolves #284
Resolves #286
Resolves #287
Resolves #242
Resolves #241
Resolves #239
Resolves #238
Resolves #234
Resolves #232
Resolves #231
Resolves #227
Resolves #271
Resolves #268

dojo#244 Feedback 1
dojo#270 Feedback 1
dojo#258 Feedback 1
dojo#251 Feedback 3
dojo#251 Feedback 4
dojo#250 Feedback 2
dojo#295 Feedback 1
dojo#295 Feedback 5
dojo#294 Feedback 3
dojo#294 Feedback 9
dojo#294 Feedback 12
dojo#294 Feedback 13
dojo#293 Feedback 1
dojo#293 Feedback 2
dojo#293 Feedback 14
dojo#293 Feedback 15
dojo#291 Feedback 1
dojo#291 Feedback 2
dojo#291 Feedback 3
dojo#291 Feedback 5
dojo#291 Feedback 6
dojo#291 Feedback 8
dojo#291 Feedback 16
dojo#289 Feedback 6

Resolves dojo#273
Resolves dojo#274
Resolves dojo#282
Resolves dojo#283
Resolves dojo#284
Resolves dojo#286
Resolves dojo#287
Resolves dojo#242
Resolves dojo#241
Resolves dojo#239
Resolves dojo#238
Resolves dojo#234
Resolves dojo#232
Resolves dojo#231
Resolves dojo#227
Resolves dojo#271
Resolves dojo#268
@umaar umaar changed the title #245 Feedback 1 A collection of tutorial text fixes Oct 23, 2017
Copy link
Member

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment... but not a blocker.

@@ -34,7 +34,7 @@ The first step will be to install our dependencies using npm:
$ npm install
```

{% instruction 'Install additional development dependency:' %}
{% instruction 'Install additional development dependencies:' %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only one dependency... are you sure you want this to be plural?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Member

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for all the tweaks!

@umaar
Copy link
Member Author

umaar commented Oct 23, 2017

@kitsonk

Only those with write access to this repository can merge pull requests.

Could merge this one yourself, or grant me access?

@umaar umaar merged commit 2e6b445 into dojo:master Oct 23, 2017
@umaar umaar deleted the tutorial-typo-and-fixes branch October 23, 2017 12:38
@dylans dylans added this to the 2017.10 milestone Oct 23, 2017
edhager pushed a commit to edhager/dojo.io that referenced this pull request Oct 26, 2017
* dojo#245 Feedback 1
dojo#244 Feedback 1
dojo#270 Feedback 1
dojo#258 Feedback 1
dojo#251 Feedback 3
dojo#251 Feedback 4
dojo#250 Feedback 2
dojo#295 Feedback 1
dojo#295 Feedback 5
dojo#294 Feedback 3
dojo#294 Feedback 9
dojo#294 Feedback 12
dojo#294 Feedback 13
dojo#293 Feedback 1
dojo#293 Feedback 2
dojo#293 Feedback 14
dojo#293 Feedback 15
dojo#291 Feedback 1
dojo#291 Feedback 2
dojo#291 Feedback 3
dojo#291 Feedback 5
dojo#291 Feedback 6
dojo#291 Feedback 8
dojo#291 Feedback 16
dojo#289 Feedback 6

Resolves dojo#273
Resolves dojo#274
Resolves dojo#282
Resolves dojo#283
Resolves dojo#284
Resolves dojo#286
Resolves dojo#287
Resolves dojo#242
Resolves dojo#241
Resolves dojo#239
Resolves dojo#238
Resolves dojo#234
Resolves dojo#232
Resolves dojo#231
Resolves dojo#227
Resolves dojo#271
Resolves dojo#268

* Fix instruction text in tutorial
edhager pushed a commit to edhager/dojo.io that referenced this pull request Oct 26, 2017
* dojo#245 Feedback 1
dojo#244 Feedback 1
dojo#270 Feedback 1
dojo#258 Feedback 1
dojo#251 Feedback 3
dojo#251 Feedback 4
dojo#250 Feedback 2
dojo#295 Feedback 1
dojo#295 Feedback 5
dojo#294 Feedback 3
dojo#294 Feedback 9
dojo#294 Feedback 12
dojo#294 Feedback 13
dojo#293 Feedback 1
dojo#293 Feedback 2
dojo#293 Feedback 14
dojo#293 Feedback 15
dojo#291 Feedback 1
dojo#291 Feedback 2
dojo#291 Feedback 3
dojo#291 Feedback 5
dojo#291 Feedback 6
dojo#291 Feedback 8
dojo#291 Feedback 16
dojo#289 Feedback 6

Resolves dojo#273
Resolves dojo#274
Resolves dojo#282
Resolves dojo#283
Resolves dojo#284
Resolves dojo#286
Resolves dojo#287
Resolves dojo#242
Resolves dojo#241
Resolves dojo#239
Resolves dojo#238
Resolves dojo#234
Resolves dojo#232
Resolves dojo#231
Resolves dojo#227
Resolves dojo#271
Resolves dojo#268

* Fix instruction text in tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants