Tutorial feedback - Using Dojo 1 Dijits

[umaar]

This feedback is for this tutorial: https://dojo.io/tutorials/1040_dojo1_dijits/

---

Feedback 1

Step 0: “Dojo 2 based form widgets and with Dojo 1 Dijits”

Should give a basic overview of what a Dojo 1 ‘dijit’ is.

---

Feedback 2

Step 1: “Install additional development dependency:”

The visual spacing between headers is squashed:

---

Feedback 3

Step 1: “Install additional development dependency:”
“Dependency” -> “dependencies”

---

Feedback 4

Step 1: “Install additional development dependency:”

There should be some explanation into what the user is installing exactly.

---

Feedback 5

Step 2: “Some of the Dojo 1 typings reference typings from this library.”

Rephrase this?

---

Feedback 6

Step 2: “Add the Dijit module typings to the include section of tsconfig.json:”

This feedback is not specific to this tutorial. However I would prefer the code blocks in tutorials highlighted the line(s) I should be paying attention to so I don’t have to keep going back and forth to the code to understand what’s already present.

---

Feedback 7

Step 2:

“If you are using your own custom Dijits, you should add your own TypeScript typings to the project. The dojo/typings can provide you examples ”

“The dojo/typings can” -> “The dojo/typings [project/repo/thing] can”

---

Feedback 8

Step 3: “You should see a rather long output indicating many dependencies have been output.”

Funny usage of the word ‘output’ twice. Maybe ‘indicating many dependencies have been created’ ?

---

Feedback 9

Step 4: “To integrate Dijits within into a Dojo 2 application”

Grammar issue here, “within into”.

---

Feedback 10

Step 4: “needs to create a DOM stub to ”

More explanation on what is meant by a DOM stub.

---

Feedback 11

Step 4: “Now that you have wrapped Dijits for use, we need to import them into their containing Dojo 2 or modules.”

There is a missing term: “into their containing Dojo 2 [missing term here?] or”

---

Feedback 12

Step 5:

“We will be using w() function”.

“using “ -> “using the”

---

Feedback 13

Step 5: “ they behave very similar to Dojo 2 widgets”

Would replace this with “ they behave similarly to Dojo 2 widgets”

---

Feedback 14

Step 5: “Coupled with the dojo-typings TypeScript typings”

A little funny to read, maybe rephrase?

---

Feedback 15

Step 5: “represent their DOM virtually”

This links to a coming soon page.

---

Feedback 16

Step 5: “When we configured the externals for our”

Needs clarification, the “externals” what?

---

Feedback 17

Step 5: “Add theme class name to src/index.html:”

Rephrase this one, bit confusing.

---

Feedback 18

Step 5: “You should now have an application that will provide you with a form that”

When following along with the tutorial up to this point, I get this error in the console panel:

This error is also present in the “completed” demo application. When you create a “new worker”, the new worker does not include the first/last name:

I was trying to explore why this might be happening, and noticed if I comment out the parent Fieldset (a dijit) which the first name + last name fields are part of, then the error disappears.

The email field does not have this problem.

---

Feedback 19

Step 6: “In this tutorial, we learned how to setup the build ...”

In this paragraph, there are 3 “we learned” style notes, I think it’d be much clearer as a bullet pointed list.

[matt-gadd]

@umaar i think Feedback 18 was due to this regression in widget-core dojo/widget-core#724.