-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[d3d8] Wine device tests fixes (Part 4) #4479
Conversation
3151535
to
12070ab
Compare
12070ab
to
0bee18f
Compare
Obligatory indication of progress: Current master: This PR: |
6db5239
to
a80c271
Compare
a80c271
to
a9ad7f8
Compare
Tested the PR with the full complement of ~300 d3d8/d3d9 games I have in my Wine prefix and there are no regressions. Could also potentially positively affect other d3d9 games that crash inexplicably, since the extra validations address some scenarios in which we get backend failures on texture creation due to invalid usage, and they're wrongly interpreted as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a little question.
I'm aiming to fix a few more d3d8/d3d9 Wine devices tests.
So far: