global updates to constants #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PUBKEYLEN to P2PKHLEN (for addresses) wif_master_privkey to hd_master_privkey (for b58-encoded private keys) 35, 53, 100, 112, 128, 200 magic numbers to constants HD_MASTERKEY_STRINGLEN to HDKEYLEN P2PKH_ADDR_STRINGLEN to P2PKHLEN WIF_UNCOMPRESSED_PRIVKEY_STRINGLEN to PRIVKEYWIFLEN tool: added PRIVKEYHEXLEN for ecc private key (in hex), updated gen_privatekey and genPrivkey address: updated generateHDMasterPubKeypair, hd_privkey_master local to hd_privkey_master_local wallet: removed ifdef from dogecoin_wallet_init, SEED type is visible
xanimo
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUBKEYLEN to P2PKHLEN (for addresses)
wif_master_privkey to hd_master_privkey (for b58-encoded private keys) 35, 53, 100, 112, 128, 200 magic numbers to constants HD_MASTERKEY_STRINGLEN to HDKEYLEN
P2PKH_ADDR_STRINGLEN to P2PKHLEN
WIF_UNCOMPRESSED_PRIVKEY_STRINGLEN to PRIVKEYWIFLEN
tool: added PRIVKEYHEXLEN for ecc private key (in hex), updated gen_privatekey and genPrivkey
address: updated generateHDMasterPubKeypair, hd_privkey_master local to hd_privkey_master_local
wallet: removed ifdef from dogecoin_wallet_init, SEED type is visible