Skip to content

Commit

Permalink
gwtproject#9727: initial work on jakarta.validation
Browse files Browse the repository at this point in the history
  • Loading branch information
@dodgex
dodgex committed Jul 15, 2023
1 parent 784ad49 commit fa50f5b
Show file tree
Hide file tree
Showing 2 changed files with 187 additions and 9 deletions.
6 changes: 5 additions & 1 deletion doc/build.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@
<pathelement location="${gwt.tools.lib}/junit/junit-4.8.2.jar" />
<pathelement location="${gwt.tools.lib}/javax/validation/validation-api-1.0.0.GA.jar" />
<pathelement location="${gwt.tools.lib}/javax/validation/validation-api-1.0.0.GA-sources.jar" />
<pathelement location="${gwt.tools.lib}/jakarta-validation/jakarta.validation-api-3.0.2/jakarta.validation-api-3.0.2.jar" />
<pathelement location="${gwt.tools.lib}/jakarta-validation/jakarta.validation-api-3.0.2/jakarta.validation-api-3.0.2-sources.jar" />
<pathelement location="${gwt.tools.lib}/selenium/selenium-java-client-driver.jar" />
<pathelement location="${gwt.tools.lib}/jakarta-servlet/jakarta.servlet-api-5.0.0/jakarta.servlet-api-5.0.0.jar" />
<!-- <pathelement location="${gwt.tools.lib}/jakarta-servlet/jakarta.servlet-api-5.0.0/jakarta.servlet-api-5.0.0.jar" />-->
<pathelement location="${gwt.tools.lib}/jakarta-servlet/jakarta.servlet-api-6.0.0/jakarta.servlet-api-6.0.0.jar" />

This comment has been minimized.

Sign in to view

Copy link
@niloc132

niloc132 Jul 15, 2023

I don't believe this should be required? No usages of the servlet api require 6 (and specifying 6 technically means dropping support for older JDKs, though making this change only in the doc project won't affect generate jars).

This comment has been minimized.

Sign in to view

Copy link
@dodgex

dodgex Jul 15, 2023

Author Owner

You are right, it is not required; I think it is still from testing if it works with 6.x. As long as it works (especially with Spring Boot 3) I have no strong feeling about using 5 or 6.
</path>

<path id="DOC_PATH">
Expand Down Expand Up @@ -83,6 +86,7 @@
</filelist>
</copy>
<replace dir="${project.build}/javadoc-src" token="javax.servlet" value="jakarta.servlet"/>
<replace dir="${project.build}/javadoc-src" token="javax.validation" value="jakarta.validation"/>
<replace dir="${project.build}/javadoc-src" token="package com.google.gwt.user.server.rpc;" value="package com.google.gwt.user.server.rpc.jakarta;"/>
<replace dir="${project.build}/javadoc-src" token="package com.google.gwt.user.server;" value="package com.google.gwt.user.server.jakarta;"/>
<replace dir="${project.build}/javadoc-src" token="package com.google.gwt.core.server" value="package com.google.gwt.core.server.jakarta"/>
Expand Down
Loading

0 comments on commit fa50f5b

Please sign in to comment.