Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented periodic ping to keep connection of transaction alive #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lukasbash
Copy link

Make sure these boxes checked before submitting your pull request.

  • [] Do only one thing
  • [] No API-breaking changes
  • [] New code/logic commented & tested

For significant changes like big bug fixes, new features, please open an issue to make an agreement on an implementation design/plan first before starting it.

What did this pull request do?

@gerhardgruber
Copy link

@lukasbash for me ok. But why did you change all the comments?

@lukasbash
Copy link
Author

@lukasbash for me ok. But why did you change all the comments?

It was automatically changed, based on the go formatter which is used on file-save in VSCode.

@lukasbash
Copy link
Author

Had to add UpdateFieldsWithoutHooks to this branch as well, as it is apparently not in master but we need it for the 🐶 compilation..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants