Remove WinPcap Dlls #331
Merged
Remove WinPcap Dlls #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces full WinPcap distribution with Developer's Pack
Issue a message to the user if WinPcap/Npcap is not found. Delay load Libpcap on Windows, so that if WinPcap/Npcap is not installed, the main application will still open.
Set dll search directory to prefer Npcap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we include WinPcap dlls, which can be non-functional on modern Windows versions.
This change removes the dlls, preferring system supplied dlls perhaps installed with Wireshark.
Likely resolution to #330