Floating Window Mode, CSV exports #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on Windows
CMake first pass See merge request rthompso/sACNView!1
Creates NSIS installer if desired x64 Release preset config enables this
Deploy on Windows See merge request rthompso/sACNView!2
And anything else using a QAbstractItemModel
Qt 5.15.3 was the last LGPL
Fix sACN Discovery See merge request rthompso/sACNView!3
Floating Window Mode See merge request rthompso/sACNView!5
Also includes a fair amount of constexpr and Qt connect() cleanup
Makes it easier to quit
Was Exclusive
docsteer
reviewed
Mar 2, 2024
docsteer
reviewed
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes a draft cmake (Windows only) that is incomplete and requires properly merging with the existing cmake work.
Closes Issue #316