Skip to content

Update Rust crate zip to v2 #943

Update Rust crate zip to v2

Update Rust crate zip to v2 #943

GitHub Actions / clippy failed Aug 19, 2024 in 0s

clippy

1 error, 1 warning

Details

Results

Message level Amount
Internal compiler error 0
Error 1
Warning 1
Note 0
Help 0

Versions

  • rustc 1.80.1 (3f5fd8dd4 2024-08-06)
  • cargo 1.80.1 (376290515 2024-07-16)
  • clippy 0.1.80 (3f5fd8d 2024-08-06)

Annotations

Check failure on line 246 in src/cli/cmd/download.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type annotations needed

error[E0283]: type annotations needed
    --> src/cli/cmd/download.rs:246:24
     |
246  |                     zw.start_file(&fname, zip::write::FileOptions::default())
     |                        ^^^^^^^^^^         ---------------------------------- type must be known at this point
     |                        |
     |                        cannot infer type of the type parameter `T` declared on the method `start_file`
     |
     = note: cannot satisfy `_: zip::write::FileOptionExtension`
     = help: the following types implement trait `zip::write::FileOptionExtension`:
               ()
               zip::write::ExtendedFileOptions
note: required by a bound in `zip::write::<impl zip::ZipWriter<W>>::start_file`
    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zip-2.1.6/src/write.rs:1131:39
     |
1131 |     pub fn start_file<S: ToString, T: FileOptionExtension>(
     |                                       ^^^^^^^^^^^^^^^^^^^ required by this bound in `zip::write::<impl ZipWriter<W>>::start_file`
help: consider specifying the generic arguments
     |
246  |                     zw.start_file::<&std::string::String, T>(&fname, zip::write::FileOptions::default())
     |                                  +++++++++++++++++++++++++++

Check warning on line 988 in src/http.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place

warning: bound is defined in more than one place
   --> src/http.rs:988:20
    |
988 |     pub fn copy_to<W: ?Sized>(&mut self, w: &mut W) -> Result<u64, Error>
    |                    ^
989 |     where
990 |         W: Write,
    |         ^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
    = note: `#[warn(clippy::multiple_bound_locations)]` on by default