warning: the `Err`-variant returned from this function is very large --> src/main.rs:16:17 | 16 | fn execute() -> Result<()> { | ^^^^^^^^^^ the `Err`-variant is at least 128 bytes | = help: try reducing the size of `dsc::error::Error`, for example by boxing large elements or replacing it with `Box<dsc::error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err = note: `#[warn(clippy::result_large_err)]` on by default

this expression borrows a value the compiler would automatically borrow: src/util/pass.rs#L22

warning: this expression borrows a value the compiler would automatically borrow --> src/util/pass.rs:22:8 | 22 | Ok((&line[len..]).trim().into()) | ^^^^^^^^^^^^^^ help: change this to: `line[len..]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: src/util/digest.rs#L29

warning: the borrowed expression implements the required traits --> src/util/digest.rs:29:20 | 29 | Ok(hex::encode(&sh.finalize())) | ^^^^^^^^^^^^^^ help: change this to: `sh.finalize()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

the borrowed expression implements the required traits: src/http/session.rs#L197

warning: the borrowed expression implements the required traits --> src/http/session.rs:197:43 | 197 | let cnt = std::fs::read_to_string(&path).context(ReadSessionFileSnafu { path })?; | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

the borrowed expression implements the required traits: src/config.rs#L210

warning: the borrowed expression implements the required traits --> src/config.rs:210:24 | 210 | std::fs::write(&file, &c).map_err(|e| ConfigError::CreateDefault { | ^^^^^ help: change this to: `file` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

this expression creates a reference which is immediately dereferenced by the compiler: src/cli/opts.rs#L342

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/cli/opts.rs:342:46 | 342 | let np = Self::read_name_val(&basic_file)?; | ^^^^^^^^^^^ help: change this to: `basic_file` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: src/cli/opts.rs#L337

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/cli/opts.rs:337:46 | 337 | let np = Self::read_name_val(&header_file)?; | ^^^^^^^^^^^^ help: change this to: `header_file` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

the following explicit lifetimes could be elided: 'a: src/cli/cmd.rs#L52

warning: the following explicit lifetimes could be elided: 'a --> src/cli/cmd.rs:52:13 | 52 | fn exec<'a>(&self, args: &'a Context) -> Result<(), Self::CmdError>; | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 52 - fn exec<'a>(&self, args: &'a Context) -> Result<(), Self::CmdError>; 52 + fn exec(&self, args: &Context) -> Result<(), Self::CmdError>; |

accessing first element with `ctx.cfg.pdf_viewer.get(0)`: src/cli/cmd/view.rs#L102

warning: accessing first element with `ctx.cfg.pdf_viewer.get(0)` --> src/cli/cmd/view.rs:102:25 | 102 | let tool = &ctx.cfg.pdf_viewer.get(0).ok_or(Error::NoPdfViewer)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ctx.cfg.pdf_viewer.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default

the borrowed expression implements the required traits: src/cli/cmd/export.rs#L286

warning: the borrowed expression implements the required traits --> src/cli/cmd/export.rs:286:62 | 286 | let rel_link_target = pathdiff::diff_paths(&link_target, &link_name_path).unwrap(); | ^^^^^^^^^^^^^^^ help: change this to: `link_name_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

the borrowed expression implements the required traits: src/cli/cmd/export.rs#L286

warning: the borrowed expression implements the required traits --> src/cli/cmd/export.rs:286:48 | 286 | let rel_link_target = pathdiff::diff_paths(&link_target, &link_name_path).unwrap(); | ^^^^^^^^^^^^ help: change this to: `link_target` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

the borrowed expression implements the required traits: src/cli/cmd/export.rs#L279

warning: the borrowed expression implements the required traits --> src/cli/cmd/export.rs:279:33 | 279 | std::fs::create_dir_all(&link_name_path).context(CreateFileSnafu)?; | ^^^^^^^^^^^^^^^ help: change this to: `link_name_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

the borrowed expression implements the required traits: src/cli/cmd/export.rs#L230

warning: the borrowed expression implements the required traits --> src/cli/cmd/export.rs:230:33 | 230 | std::fs::create_dir_all(&item_dir).context(CreateFileSnafu)?; | ^^^^^^^^^ help: change this to: `item_dir` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

this `impl` can be derived: src/cli/cmd/export.rs#L20

warning: this `impl` can be derived --> src/cli/cmd/export.rs:20:1 | 20 | / impl Default for LinkNaming { 21 | | fn default() -> Self { 22 | | LinkNaming::Id 23 | | } 24 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it... | 14 + #[derive(Default)] 15 | pub enum LinkNaming { | help: ...and mark the default variant | 16 ~ #[default] 17 ~ Id, |

the borrowed expression implements the required traits: src/cli/cmd/download.rs#L142

warning: the borrowed expression implements the required traits --> src/cli/cmd/download.rs:142:53 | 142 | ... std::fs::create_dir_all(&parent).context(CreateFileSnafu)?; | ^^^^^^^ help: change this to: `parent` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

you are explicitly cloning with `.map()`: src/cli/cmd/admin.rs#L110

warning: you are explicitly cloning with `.map()` --> src/cli/cmd/admin.rs:110:18 | 110 | let secret = opts | __________________^ 111 | | .admin_secret 112 | | .as_ref() 113 | | .or(ctx.cfg.admin_secret.as_ref()) 114 | | .map(String::clone); | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default help: consider calling the dedicated `cloned` method | 110 ~ let secret = opts 111 + .admin_secret 112 + .as_ref() 113 ~ .or(ctx.cfg.admin_secret.as_ref()).cloned(); |

bound is defined in more than one place: src/http.rs#L988

warning: bound is defined in more than one place --> src/http.rs:988:20 | 988 | pub fn copy_to<W: ?Sized>(&mut self, w: &mut W) -> Result<u64, Error> | ^ 989 | where 990 | W: Write, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default

cicd-mac

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

cicd-mac

The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

cicd-mac

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

cicd-mac