-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Trust Registry
and introduce on-chain did:key
support
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegnn
force-pushed
the
trust-registry-did-method-key
branch
from
October 19, 2023 13:42
474a7cf
to
a07a231
Compare
olegnn
force-pushed
the
trust-registry-did-method-key
branch
2 times, most recently
from
October 19, 2023 16:58
bf8708d
to
be46409
Compare
olegnn
force-pushed
the
trust-registry-did-method-key
branch
from
October 19, 2023 17:09
be46409
to
d338ef1
Compare
olegnn
force-pushed
the
trust-registry-did-method-key
branch
4 times, most recently
from
October 22, 2023 15:22
9b8c4b7
to
5c0388b
Compare
olegnn
force-pushed
the
trust-registry-did-method-key
branch
from
October 22, 2023 15:27
5c0388b
to
cc63dc8
Compare
lovesh
reviewed
Oct 27, 2023
lovesh
reviewed
Oct 27, 2023
lovesh
reviewed
Oct 27, 2023
lovesh
reviewed
Oct 27, 2023
/// Adds a new schema metadata entry (entries). | ||
/// The DID signature signer must be the `Convener` owning this Trust Registry. | ||
#[pallet::weight(SubstrateWeight::<T>::add_schema_metadata(add_schema_metadata, sig))] | ||
pub fn add_schema_metadata( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is add_schema_metadata
supposed to replace existing metadata? If yes, then it should be called set_schema_metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not supposed
lovesh
force-pushed
the
trust-registry-did-method-key
branch
from
October 27, 2023 16:16
0c77c00
to
1a8349d
Compare
Signed-off-by: lovesh <[email protected]>
lovesh
force-pushed
the
trust-registry-did-method-key
branch
from
October 27, 2023 16:23
1a8349d
to
664ac4d
Compare
lovesh
reviewed
Oct 27, 2023
…k/dock-substrate into trust-registry-did-method-key
olegnn
force-pushed
the
trust-registry-did-method-key
branch
from
October 27, 2023 18:31
73dfd50
to
97f4249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.