remove test-dependencies in favor of native go #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
To be fair. the "diff" (actual/expected) may be a bit wonky 😅 - let me know if that's a problem |
|
Yeah a bit, do you have an issue with transitive deps on another repo? |
|
Not directly, so I'm fine waiting with this. I think I originally looked at what it was used for, and all seemed "trivial enough to not need a dependency for that", but now looking again, the reason I didn't push may have been because of this specific case. I'll give it some thinking (perhaps we can only add go-cmp (e.g.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I had this in my local checkout, but never committed or pushed it 😂. Don't know where I left off, but it seems to be complete 🤷♂️