Update docs for Caddy image with a fix to its reload feature #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whalelines
approved these changes
Aug 26, 2024
tianon
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Agreed, seems OK to me -- cc @hairyhenderson @francislavoie (caddy image maintainers)
|
(Looks like there's also a bit of trailing whitespace that our |
Co-authored-by: Francis Lavoie <[email protected]>
Co-authored-by: Francis Lavoie <[email protected]>
Co-authored-by: Francis Lavoie <[email protected]>
…mand Co-authored-by: Francis Lavoie <[email protected]>
BjoernLudwigPTB
commented
Aug 28, 2024
Co-authored-by: Francis Lavoie <[email protected]>
|
@francislavoie Thanks for your recent review. I applied the agreed upon changes. Should be ready for approval by you now. |
|
@whalelines @tianon All conversations and issues are resolved. Is a formal approval by Francis needed or can we merge this PR as is? |
|
LGTM 👍 |
|
Looks good, thanks to you both 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last August unexpected behaviour of the graceful reload feature was discussed in this upstream issue and a fix proposed alongside the suggestion to add that fix to the docs. This has not yet happened but should be solved by this PR.
This is my first contribution here, so if there is anything I should address to finalize this PR, I ask you kindly to let me know.
This one resolves #1858 as well.