Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git to CLI variants #504

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

tianon
Copy link
Member

@tianon tianon commented Jul 1, 2024

  • docker build . / docker buildx build . might shell out to git to ask about the context directory's git status
  • DOCKER_BUILDKIT=0 docker build https://example/foo.git will run git in the client context
  • docker buildx build https://example/foo.git will run git in the daemon context

#482 (comment)

- `docker build .` / `docker buildx build .` might shell out to git to ask about the context directory's `git status`
- `DOCKER_BUILDKIT=0 docker build https://example/foo.git` will run git in the client context
- `docker buildx build https://example/foo.git` will run git in the daemon context
@tianon
Copy link
Member Author

tianon commented Jul 1, 2024

For now, I've just added git to the CLI variants without removing it from the DinD variants because the later apk add should be a no-op, but I'm open to removing it and relying on the FROM relationship

Copy link
Contributor

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it's good that DIND keeps git.

@yosifkit yosifkit merged commit b34caac into docker-library:master Jul 2, 2024
14 checks passed
@yosifkit yosifkit deleted the git-cli branch July 2, 2024 23:37
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jul 3, 2024
Changes:

- docker-library/docker@b34caac: Merge pull request docker-library/docker#504 from infosiftr/git-cli
- docker-library/docker@b348a31: Add `git` to CLI variants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants