Also load ip6_tables when trying to load ip_tables
#501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't used/necessary in the default configuration until Docker 27+, but it was optional behavior before that, so it's prudent for us to also try loading it any time we know we're not using nftables / have explicitly requested "legacy" `iptables`.
|
I thought we'd already been doing this, but apparently I was misremembering, probably because we do check the |
yosifkit
approved these changes
Jun 20, 2024
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jun 20, 2024
Changes: - docker-library/docker@7576de6: Update 27-rc to 27.0.1-rc.1 - docker-library/docker@5753ec0: Merge pull request docker-library/docker#501 from infosiftr/ip6tables - docker-library/docker@255b5d8: Update 27-rc to compose 2.27.2 - docker-library/docker@879ff34: Update 26 to compose 2.27.2 - docker-library/docker@b3aedde: Update 25 to compose 2.27.2 - docker-library/docker@79288b2: Update 24 to compose 2.27.2 - docker-library/docker@12a00d7: Also load `ip6_tables` when trying to load `ip_tables` - docker-library/docker@b9cd989: Update 27-rc to buildx 0.15.1 - docker-library/docker@e010b57: Update 26 to buildx 0.15.1 - docker-library/docker@670d387: Update 25 to buildx 0.15.1 - docker-library/docker@e32a14a: Update 24 to buildx 0.15.1
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jun 21, 2024
Changes: - docker-library/docker@c4710de: Update 27-rc to compose 2.28.0 - docker-library/docker@d83adb6: Update 26 to compose 2.28.0 - docker-library/docker@14d04d4: Update 25 to compose 2.28.0 - docker-library/docker@81526b8: Update 24 to compose 2.28.0 - docker-library/docker@7576de6: Update 27-rc to 27.0.1-rc.1 - docker-library/docker@5753ec0: Merge pull request docker-library/docker#501 from infosiftr/ip6tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't used/necessary in the default configuration until Docker 27+, but it was optional behavior before that, so it's prudent for us to also try loading it any time we know we're not using nftables / have explicitly requested "legacy"
iptables.See also:
cc/fyi @robmry @akerouanton ❤️