Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildroot to 2024.02.1 #193

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

tianon
Copy link
Member

@tianon tianon commented Mar 26, 2024

No description provided.

@tianon
Copy link
Member Author

tianon commented Mar 26, 2024

$ docker run -it --rm --pull=always alpine:edge
edge: Pulling from library/alpine
Digest: sha256:67b8a3c4c19bbdd43de723881bc536758f5e780f8d32ef8f5ef2b72f769a3e78
Status: Image is up to date for alpine:edge
/ # apk add --no-cache --quiet curl
/ # curl --version
Error relocating /usr/lib/libcurl.so.4: SSL_get0_group_name: symbol not found

😭

@tianon
Copy link
Member Author

tianon commented Mar 26, 2024

There's another report of the same issue in libsdl-org/SDL#9357 (comment), which I think is probably because a bump of libssl3 was uploaded to Alpine Edge, but the things rebuilt against it don't seem to have a dependency relationship that forces it to be updated appropriately on package install, so they fail with missing symbols. 😞

@tianon
Copy link
Member Author

tianon commented Mar 27, 2024

@tianon
Copy link
Member Author

tianon commented Mar 27, 2024

I don't think the Alpine issue is necessarily a blocker here -- it will only impede the rebuild on riscv64 🤔

Perhaps we add a (temporary) patch to explicitly upgrade libssl3 in our build, but only on alpine:edge?

@yosifkit
Copy link
Member

Perhaps we add a (temporary) patch to explicitly upgrade libssl3 in our build, but only on alpine:edge?

That seems fine, but is probably a full apk upgrade (or the current set of installed packages) since it seems to go deeper alpinelinux/docker-alpine#383 (comment) 👀

$ docker run -it --rm alpine:edge
/ # apk upgrade libssl3
fetch https://dl-cdn.alpinelinux.org/alpine/edge/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/edge/community/x86_64/APKINDEX.tar.gz
(1/1) Upgrading libssl3 (3.1.5-r5 -> 3.2.1-r1)
OK: 8 MiB in 14 packages
/ # apk info
Error relocating /lib/libssl.so.3: BIO_err_is_non_fatal: symbol not found
Error relocating /lib/libssl.so.3: BIO_s_dgram_mem: symbol not found
Error relocating /lib/libssl.so.3: OSSL_STACK_OF_X509_free: symbol not found
Error relocating /lib/libssl.so.3: OSSL_ERR_STATE_restore: symbol not found
Error relocating /lib/libssl.so.3: ERR_count_to_mark: symbol not found
Error relocating /lib/libssl.so.3: BIO_get_rpoll_descriptor: symbol not found
Error relocating /lib/libssl.so.3: BIO_get_wpoll_descriptor: symbol not found
Error relocating /lib/libssl.so.3: BIO_recvmmsg: symbol not found
Error relocating /lib/libssl.so.3: OSSL_ERR_STATE_save: symbol not found
Error relocating /lib/libssl.so.3: X509_STORE_CTX_init_rpk: symbol not found
Error relocating /lib/libssl.so.3: OSSL_ERR_STATE_new: symbol not found
Error relocating /lib/libssl.so.3: OSSL_ERR_STATE_free: symbol not found
Error relocating /lib/libssl.so.3: BIO_sendmmsg: symbol not found
Error relocating /lib/libssl.so.3: OSSL_ERR_STATE_save_to_mark: symbol not found

@tianon
Copy link
Member Author

tianon commented Mar 27, 2024

I think that's really just an artifact of those packages both coming from the same openssl source package, and thus needing to be upgraded at the same time for inter-binary-package consistency (something that I would've expected to be handled via explicit dependency relationships 🙈). Doing just libssl3 and libcrypto3 is sufficient. I don't think there's a way to convince apk list to give us a list of all packages from a particular source package (so we could explicitly upgrade all of them together in an automated way without going full-hog), but it's a small enough set that I feel pretty confident in only doing the two upgrades.

@tianon
Copy link
Member Author

tianon commented Mar 27, 2024

#194

@tianon
Copy link
Member Author

tianon commented Mar 27, 2024

Do you think this is worth rebasing or should we just merge it and go ahead? I have a very high degree of confidence it will build just fine.

@yosifkit yosifkit merged commit e8f737b into docker-library:master Mar 27, 2024
12 of 14 checks passed
@yosifkit yosifkit deleted the buildroot-2024.02.1 branch March 27, 2024 22:10
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 28, 2024
Changes:

- docker-library/busybox@e8f737b: Merge pull request docker-library/busybox#193 from infosiftr/buildroot-2024.02.1
- docker-library/busybox@21db221: Merge pull request docker-library/busybox#194 from infosiftr/alpine-edge
- docker-library/busybox@f4bd993: Add `apk upgrade libssl3 libcrypto3` as temporary Alpine Edge woes balm
- docker-library/busybox@b807fe5: Update buildroot to 2024.02.1
- docker-library/busybox@911b553: Update metadata for mips64le
- docker-library/busybox@a3246b7: Update metadata for i386
- docker-library/busybox@e8530b1: Update metadata for arm64v8
- docker-library/busybox@ef28338: Update metadata for arm32v7
- docker-library/busybox@72b8495: Update metadata for arm32v5
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 28, 2024
Changes:

- docker-library/busybox@3afd681: Update metadata for mips64le
- docker-library/busybox@3ced3b8: Update metadata for i386
- docker-library/busybox@69a65f3: Update metadata for arm64v8
- docker-library/busybox@688027b: Update metadata for arm32v7
- docker-library/busybox@5928a1b: Update metadata for arm32v5
- docker-library/busybox@e8f737b: Merge pull request docker-library/busybox#193 from infosiftr/buildroot-2024.02.1
- docker-library/busybox@21db221: Merge pull request docker-library/busybox#194 from infosiftr/alpine-edge
- docker-library/busybox@f4bd993: Add `apk upgrade libssl3 libcrypto3` as temporary Alpine Edge woes balm
- docker-library/busybox@b807fe5: Update buildroot to 2024.02.1
- docker-library/busybox@911b553: Update metadata for mips64le
- docker-library/busybox@a3246b7: Update metadata for i386
- docker-library/busybox@e8530b1: Update metadata for arm64v8
- docker-library/busybox@ef28338: Update metadata for arm32v7
- docker-library/busybox@72b8495: Update metadata for arm32v5
martin-g pushed a commit to martin-g/docker-official-images that referenced this pull request Apr 3, 2024
Changes:

- docker-library/busybox@3afd681: Update metadata for mips64le
- docker-library/busybox@3ced3b8: Update metadata for i386
- docker-library/busybox@69a65f3: Update metadata for arm64v8
- docker-library/busybox@688027b: Update metadata for arm32v7
- docker-library/busybox@5928a1b: Update metadata for arm32v5
- docker-library/busybox@e8f737b: Merge pull request docker-library/busybox#193 from infosiftr/buildroot-2024.02.1
- docker-library/busybox@21db221: Merge pull request docker-library/busybox#194 from infosiftr/alpine-edge
- docker-library/busybox@f4bd993: Add `apk upgrade libssl3 libcrypto3` as temporary Alpine Edge woes balm
- docker-library/busybox@b807fe5: Update buildroot to 2024.02.1
- docker-library/busybox@911b553: Update metadata for mips64le
- docker-library/busybox@a3246b7: Update metadata for i386
- docker-library/busybox@e8530b1: Update metadata for arm64v8
- docker-library/busybox@ef28338: Update metadata for arm32v7
- docker-library/busybox@72b8495: Update metadata for arm32v5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants