This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
bugfix: use same bufio.Reader for all requests in one connection. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old code create bufio.Reader for each request. When using pipeline mode, bufio.Reader may eat some input data which belong to next request.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My colleague found that this code do not work well in PIPELINE mode.
The reason is that the old code create
bufio.Readerfor each request. When using pipeline mode,bufio.Readermay eat some input data which belong to next request.The old code works well when client waits for server response before sending next request. While Reader is still trying to read more data to its buffer, there's nothing more but exactly current request data in conn.