Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Protobuf load/export feature #193

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Aug 27, 2020

I'm about to refactor the whole codebase to accommodate multiple data types in tree models (#189 (comment)), and the current Protobuf spec is deficient in accommodating multiple data types.

Since supporting LightGBM model is a higher priority than Protobuf support, I am removing Protobuf load/export feature for the time being.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020

Codecov Report

Merging #193 into mainline will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #193      +/-   ##
==============================================
+ Coverage       82.15%   82.20%   +0.04%     
+ Complexity         56       54       -2     
==============================================
  Files              86       85       -1     
  Lines            5890     5625     -265     
  Branches           48       48              
==============================================
- Hits             4839     4624     -215     
+ Misses           1022      973      -49     
+ Partials           29       28       -1     
Impacted Files Coverage Δ Complexity Δ
include/treelite/frontend.h 50.00% <ø> (ø) 0.00 <0.00> (ø)
python/treelite/frontend.py 73.42% <ø> (-0.37%) 0.00 <0.00> (ø)
src/c_api/c_api.cc 75.96% <ø> (-0.76%) 0.00 <0.00> (ø)
src/compiler/ast/ast.h 36.90% <ø> (ø) 0.00 <0.00> (ø)
...c/main/java/ml/dmlc/treelite4j/java/Predictor.java 59.25% <0.00%> (-3.71%) 17.00% <0.00%> (-2.00%)
include/treelite/tree_impl.h 88.94% <0.00%> (-0.27%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70bdebe...c918824. Read the comment docs.

@hcho3 hcho3 merged commit 996114f into dmlc:mainline Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants