allow watchlist to be NamedTuple #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice that it's now even covered by a test. Thanks! |
|
Should we add a |
|
I will get it merged if someone wants to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent addition of early stopping rounds broke the ability to pass
watchlistasNamedTuple. Probably not narrowing the type in the first place was a mistake, and we should have picked one, but in the meantime it would be breaking to remove either. This PR restores the ability to passwatchlistas any iterable of pairs of which the keys can be converted to strings.See JuliaAI/MLJXGBoostInterface.jl#46 (comment)