Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndarray: change internal api of mul/div to help autograd #366

Merged
merged 1 commit into from
Dec 9, 2017
Merged

ndarray: change internal api of mul/div to help autograd #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions src/ndarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,12 +648,12 @@ import Base: *

Currently only multiplication a scalar with an `NDArray` is implemented.
"""
*(x:: NDArray, y::Real) = x .* y
*(x::Real, y::NDArray) = y .* x
*(x::NDArray, y::Real) = _mul_scalar(x, scalar = y)
*(y::Real, x::NDArray) = _mul_scalar(x, scalar = y)

broadcast_(::typeof(*), x::NDArray, y::NDArrayOrReal) =
mul_to!(copy(x, context(x)), y)
broadcast_(::typeof(*), x::Real, y::NDArray) = y .* x
broadcast_(::typeof(*), x::NDArray, y::Real) = x * y
broadcast_(::typeof(*), y::Real, x::NDArray) = x * y
broadcast_(::typeof(*), x::NDArray, y::NDArray) = _mul(x, y)

"""
*(A::NDArray, B::NDArray)
Expand Down Expand Up @@ -701,25 +701,23 @@ of the same shape.

* Matrix division (solving linear systems) is not implemented yet.
"""
/(x::NDArray, y::Real) = x ./ y
/(x::NDArray, y::Real) = _div_scalar(x, scalar = y)

broadcast_(::typeof(/), x::NDArray, y::NDArrayOrReal) =
div_from!(copy(x, context(x)), y)

broadcast_(::typeof(/), x::Real, y::NDArray) =
rdiv_from!(x, copy(y, context(y)))
broadcast_(::typeof(/), x::NDArray, y::NDArray) = _div(x, y)
broadcast_(::typeof(/), x::NDArray, y::Real) = _div_scalar(x, scalar = y)
broadcast_(::typeof(/), y::Real, x::NDArray) = _rdiv_scalar(x, scalar = y)

import Base: ^

# document of `.^` is merged into SymbolicNode's

broadcast_(::typeof(^), x::NDArray, y::NDArray) = _power(x, y)
broadcast_(::typeof(^), x::NDArray, s::Real) = _power_scalar(x, scalar=s)
broadcast_(::typeof(^), s::Real, x::NDArray) = _rpower_scalar(x, scalar=s)
broadcast_(::typeof(^), x::NDArray, s::Real) = _power_scalar(x, scalar = s)
broadcast_(::typeof(^), s::Real, x::NDArray) = _rpower_scalar(x, scalar = s)

broadcast_(::typeof(^), ::Irrational{:e}, x::NDArray) = exp(x)
broadcast_(::typeof(^), x::NDArray, s::Irrational) = _power_scalar(x, scalar=s)
broadcast_(::typeof(^), s::Irrational, x::NDArray) = _rpower_scalar(x, scalar=s)
broadcast_(::typeof(^), x::NDArray, s::Irrational) = _power_scalar(x, scalar = s)
broadcast_(::typeof(^), s::Irrational, x::NDArray) = _rpower_scalar(x, scalar = s)

"""
fill!(arr::NDArray, x)
Expand Down