Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pymongoarrow optional #568

Conversation

Pipboyguy
Copy link
Collaborator

@Pipboyguy Pipboyguy self-assigned this Sep 20, 2024
Copy link
Contributor

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just make sure that all conflicts are resolved

…older-version-of-mongodbpymongo

# Conflicts:
#	tests/mongodb/test_mongodb_source.py
@Pipboyguy Pipboyguy requested a review from rudolfix September 23, 2024 13:49
@rudolfix rudolfix merged commit 5312382 into master Oct 1, 2024
14 checks passed
@rudolfix rudolfix deleted the 567-make-pymongoarrow-optional-to-support-older-version-of-mongodbpymongo branch October 1, 2024 08:57
neuromantik33 pushed a commit to neuromantik33/verified-sources that referenced this pull request Oct 5, 2024
* Add test for support for loading MongoDB data without pymongoarrow.

Signed-off-by: Marcel Coetzee <[email protected]>

* Make pymongoarrow optional in requirements file

Signed-off-by: Marcel Coetzee <[email protected]>

---------

Signed-off-by: Marcel Coetzee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pymongoarrow optional to support older version of mongodb/pymongo
2 participants