Code Cleanup - Github source #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit__,py" as well. That caused the confusion mentioned in issue #294. Now all the helper functions are moved to "helper.py".
dat-a-man
changed the title
sources/github/helpers.py
Outdated
| def get_rest_pages(access_token: str, query: str) -> Iterator[List[StrAny]]: | ||
| url = REST_API_BASE_URL + query | ||
| while True: | ||
| def _get_rest_pages(access_token: str, query: str) -> Iterator[List[StrAny]]: |
There was a problem hiding this comment.
you import this function to another script, so imo prefix "_", which means "private function", doesn't make sense.
you can keep it like get_rest_pages.
same for get_reactions_data
AstrakhantsevaAA
approved these changes
Dec 1, 2023
AstrakhantsevaAA
requested changes
Dec 1, 2023
sources/github/helpers.py
Outdated
| ).json() | ||
| def _request() -> requests.Response: | ||
| r = requests.post( | ||
| "https://api.github.com/graphql", |
There was a problem hiding this comment.
use GRAPHQL_API_BASE_URL instead of "https://api.github.com/graphql"
sources/github/helpers.py
Outdated
| print(f"got page {url}, requests left: " + r.headers["x-ratelimit-remaining"]) | ||
| return r | ||
|
|
||
| url = "https://api.github.com" + query |
There was a problem hiding this comment.
use REST_API_BASE_URL
sources/github/helpers.py
Outdated
| ) | ||
| return r | ||
|
|
||
| next_page_url = "https://api.github.com" + query |
There was a problem hiding this comment.
use REST_API_BASE_URL instead of "https://api.github.com"
AstrakhantsevaAA
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the rest of the API helper functions were defined two times, one in "init.py" and one in "helper.py" as well. This was the issue mentioned in issue #294. Now, all the helper functions are moved to "helper.py".
Tell us what you do here
verified source)Relevant issue
issue # 294
More PR info