allows naming conventions to be changed

dlt/common/data_writers/__init__.py

@@ -11,7 +11,7 @@
 from dlt.common.data_writers.escape import (
     escape_redshift_literal,
     escape_redshift_identifier,
-    escape_bigquery_identifier,
+    escape_hive_identifier,
 )
 
 __all__ = [
@@ -26,5 +26,5 @@
     "new_file_id",
     "escape_redshift_literal",
     "escape_redshift_identifier",
-    "escape_bigquery_identifier",
+    "escape_hive_identifier",
 ]

dlt/common/data_writers/escape.py

@@ -124,18 +124,18 @@ def escape_redshift_identifier(v: str) -> str:
 escape_dremio_identifier = escape_postgres_identifier
 
 
-def escape_bigquery_identifier(v: str) -> str:
+def escape_hive_identifier(v: str) -> str:
     # https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical
     return "`" + v.replace("\\", "\\\\").replace("`", "\\`") + "`"
 
 
 def escape_snowflake_identifier(v: str) -> str:
     # Snowcase uppercase all identifiers unless quoted. Match this here so queries on information schema work without issue
     # See also https://docs.snowflake.com/en/sql-reference/identifiers-syntax#double-quoted-identifiers
-    return escape_postgres_identifier(v.upper())
+    return escape_postgres_identifier(v)
 
 
-escape_databricks_identifier = escape_bigquery_identifier
+escape_databricks_identifier = escape_hive_identifier
 
 
 DATABRICKS_ESCAPE_DICT = {"'": "\\'", "\\": "\\\\", "\n": "\\n", "\r": "\\r"}

dlt/common/destination/capabilities.py

@@ -8,6 +8,7 @@
     Tuple,
     Set,
     Protocol,
+    Union,
     get_args,
 )
 
@@ -19,8 +20,7 @@
     DestinationLoadingViaStagingNotSupported,
     DestinationLoadingWithoutStagingNotSupported,
 )
-from dlt.common.utils import identity
-
+from dlt.common.normalizers.naming import NamingConvention
 from dlt.common.arithmetics import DEFAULT_NUMERIC_PRECISION, DEFAULT_NUMERIC_SCALE
 from dlt.common.wei import EVM_DECIMAL_PRECISION
 
@@ -59,9 +59,15 @@ class DestinationCapabilitiesContext(ContainerInjectableContext):
     """Recommended file size in bytes when writing extract/load files"""
     preferred_staging_file_format: Optional[TLoaderFileFormat] = None
     supported_staging_file_formats: Sequence[TLoaderFileFormat] = None
+    format_datetime_literal: Callable[..., str] = None
     escape_identifier: Callable[[str], str] = None
+    "Escapes table name, column name and other identifiers"
     escape_literal: Callable[[Any], Any] = None
-    format_datetime_literal: Callable[..., str] = None
+    "Escapes string literal"
+    casefold_identifier: Callable[[str], str] = str
+    """Casing function applied by destination to represent case insensitive identifiers."""
+    has_case_sensitive_identifiers: bool = None
+    """Tells if identifiers in destination are case sensitive, before case_identifier function is applied"""
     decimal_precision: Tuple[int, int] = None
     wei_precision: Tuple[int, int] = None
     max_identifier_length: int = None
@@ -72,7 +78,7 @@ class DestinationCapabilitiesContext(ContainerInjectableContext):
     is_max_text_data_type_length_in_bytes: bool = None
     supports_transactions: bool = None
     supports_ddl_transactions: bool = None
-    naming_convention: str = "snake_case"
+    naming_convention: Union[str, NamingConvention] = "snake_case"
     alter_add_multi_column: bool = True
     supports_truncate_command: bool = True
     schema_supports_numeric_precision: bool = True
@@ -91,6 +97,7 @@ class DestinationCapabilitiesContext(ContainerInjectableContext):
     @staticmethod
     def generic_capabilities(
         preferred_loader_file_format: TLoaderFileFormat = None,
+        naming_convention: Union[str, NamingConvention] = None,
         loader_file_format_adapter: LoaderFileFormatAdapter = None,
         supported_table_formats: Sequence["TTableFormat"] = None,  # type: ignore[name-defined] # noqa: F821
     ) -> "DestinationCapabilitiesContext":
@@ -102,9 +109,12 @@ def generic_capabilities(
         caps.loader_file_format_adapter = loader_file_format_adapter
         caps.preferred_staging_file_format = None
         caps.supported_staging_file_formats = []
+        caps.naming_convention = naming_convention or caps.naming_convention
+        caps.escape_identifier = str
         caps.supported_table_formats = supported_table_formats or []
-        caps.escape_identifier = identity
         caps.escape_literal = serialize_value
+        caps.casefold_identifier = str
+        caps.has_case_sensitive_identifiers = True
         caps.format_datetime_literal = format_datetime_literal
         caps.decimal_precision = (DEFAULT_NUMERIC_PRECISION, DEFAULT_NUMERIC_SCALE)
         caps.wei_precision = (EVM_DECIMAL_PRECISION, 0)