add mark function to emit resource hints from decorated function #938
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| validator: ValidateItem | ||
| original_columns: TTableHintTemplate[TAnySchemaColumns] | ||
|
|
||
|
|
||
| class HintsMeta: | ||
| __slots__ = "hints" |
There was a problem hiding this comment.
i never heard of this before, this is purely here for performance reasons, right?
There was a problem hiding this comment.
yes, this is performance. instead of creating and maintaining dict, class have slots (and its fields are frozen). almost as good as tuple
dlt/extract/hints.py
Outdated
| @@ -176,7 +232,12 @@ def apply_hints( | |||
| # normalize columns | |||
| columns = ensure_table_schema_columns(columns) | |||
| # this updates all columns with defaults | |||
| print("PREV") | |||
| @@ -202,8 +263,13 @@ def apply_hints( | |||
| ) | |||
| if schema_contract is not None: | |||
| t["schema_contract"] = schema_contract | |||
| if table_format is not None: | |||
There was a problem hiding this comment.
this is kind of unrelated, but what about a utility function that does all of the table_format updating (and all other props that behave the same way) in one line? this makes it all more readable and you can also use it in make_hints (although the popping part is not needed there really)
There was a problem hiding this comment.
do you mean code refactor? yeah maybe there's time to do that. I'll merge this as it is though
Description
dlt.mark.with_hintswhich allow to create/update resource hints from within decorated function. allows lazy creation of table schema during extract process