gdrive fsspec #738
Closed
gdrive fsspec #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some changes to the filesystem module in order to support gdrive.
Additional Context
In gdrive when parsing a directory that is not the user root, eg. a directory that is shared with the user, you need to provide
root_file_id, this PR adds support for it without changingGcpCredentials, it also removes thenetlocthat contains theroot_file_idbefore requesting the data to fsspec.For fetching a file using file_id the user will need to provide something like:
gdrive:///path?RootId=<file_id>If the user wants to get the root from the user gdrive account the netloc should not be provided:
gdrive:///pathdepends on the PR