-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2020 #2151 - fixes dbt 1.8.6 and arrow dict types #2175
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8609fe8
to
a0100ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -135,15 +128,10 @@ def run_dbt_command( | |||
runner_args = (global_args or []) + [command] + args # type: ignore | |||
|
|||
with dbt.logger.log_manager.applicationbound(): | |||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like with this change we're not supporting dbt<1.5
anymore. We could write a note in the docs that 1.5.2
(looking at test_runner_dbt_versions.py
) is the minimum tested/supported version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right! the fact is we do not support <1.5 for a long time already...
Description
fixes #2151
fixes #2020