Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: indent subsection about references in nested tables #2161

Closed
wants to merge 2 commits into from
Closed

docs: indent subsection about references in nested tables #2161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ebb447
docs: remove outdated subsection
joscha Dec 18, 2024
3aaa338
Update schema.md
joscha Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/website/docs/general-usage/schema.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ You are able to bring your own `row_key` by adding a `_dlt_id` column/field to y

`merge` write disposition requires an additional nested reference that goes from **nested** to **root** table, skipping all parent tables in between. This reference is created by [adding a column with a hint](incremental-loading.md#forcing-root-key-propagation) `root_key` (named `_dlt_root_id` by default) to nested tables.

### Table references
You can annotate tables with table references. This feature is coming soon.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joscha thanks for the PR. The section above describes nested references, not table references, if you read the whole references section you can see that this differentiation is done at the beginning of the section. We have a conceptual implementation of these table references but they are not available in the core library yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - should this be #### then, to be one level below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it in 3aaa338

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, not really, ### is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I don't think it makes sense:

2024-12-18_10-52

#### Table references
You can annotate nested tables with table references. This feature is coming soon.

## Schema settings

Expand Down
Loading