Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare dataset release & docs updates #2126

Merged
merged 36 commits into from
Dec 15, 2024
Merged

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Dec 9, 2024

Description

Makes dataset interface public and updates transformation and dataaccess snippets in docs to use this interface.

Note: For linting to pass on this PR, ibis dataset accessing must be merged first.

Stuff that happened:

  • Remove sql_client reference in docs where not needed
  • Updated sql_client sql queries to something more useful where it makes sense and added info about accessing data with datasets
  • Reworked the transformations section
  • Currently not yet added any datasets stuff to our quick starts, only to the rest_api tutorial. @rudolfix should I add this there?

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 16954fb
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/675c47681cf2a7000827ce9f
😎 Deploy Preview https://deploy-preview-2126--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sh-rp sh-rp marked this pull request as ready for review December 9, 2024 17:15
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is very good

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's merge ibis first to see if docs will build again.

I'd show how to get data frame in https://dlthub.com/docs/intro "Python data structures" tab - to read content of the table as df

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. but let's wait for the final feedback

Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Suggest some small corrections

docs/website/docs/dlt-ecosystem/destinations/duckdb.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/transformations/index.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/transformations/index.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/transformations/index.md Outdated Show resolved Hide resolved
docs/website/docs/dlt-ecosystem/transformations/index.md Outdated Show resolved Hide resolved
docs/website/docs/general-usage/dataset-access/dataset.md Outdated Show resolved Hide resolved
docs/website/docs/general-usage/dataset-access/dataset.md Outdated Show resolved Hide resolved
docs/website/docs/tutorial/load-data-from-an-api.md Outdated Show resolved Hide resolved
docs/website/docs/tutorial/load-data-from-an-api.md Outdated Show resolved Hide resolved
docs/website/docs/tutorial/load-data-from-an-api.md Outdated Show resolved Hide resolved
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed a typo

docs/website/docs/intro.md Outdated Show resolved Hide resolved
@sh-rp sh-rp merged commit b8bac75 into devel Dec 15, 2024
56 of 59 checks passed
@sh-rp sh-rp deleted the feat/prepare-dataset-release branch December 15, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants