Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports, cosmetics for core sources #1833

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Fix imports, cosmetics for core sources #1833

merged 5 commits into from
Sep 17, 2024

Conversation

VioletM
Copy link
Contributor

@VioletM VioletM commented Sep 17, 2024

No description provided.

@VioletM VioletM requested review from burnash and rahuljo September 17, 2024 10:00
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 5b7f613
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66e977901898010008730f0b
😎 Deploy Preview https://deploy-preview-1833--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

CONTRIBUTING.md Outdated
@@ -4,7 +4,7 @@ Thank you for considering contributing to **dlt**! We appreciate your help in ma

## Table of Contents

1. [Getting Started](#getting-started)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

CONTRIBUTING.md Outdated
@@ -4,7 +4,7 @@ Thank you for considering contributing to **dlt**! We appreciate your help in ma

## Table of Contents

1. [Getting Started](#getting-started)
1. [Getting Started](#intro)
Copy link
Collaborator

@burnash burnash Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. [Getting Started](#intro)
1. [Before You Begin](#before-you-begin)

sh-rp and others added 2 commits September 17, 2024 13:16
Fix some broken links (will need  cleanup)
Allow broken links in docs as v 0.5.4. still has some
burnash
burnash previously approved these changes Sep 17, 2024
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @VioletM

rahuljo
rahuljo previously approved these changes Sep 17, 2024
@VioletM VioletM dismissed stale reviews from rahuljo and burnash via 5b7f613 September 17, 2024 12:35
@VioletM VioletM merged commit 61ba65d into devel Sep 17, 2024
51 checks passed
@rudolfix rudolfix deleted the docs/fix-imports branch October 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants