Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the documentation #1784

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

dat-a-man
Copy link
Collaborator

Description

Updated the incremental docs

Related Issues

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 171dfed
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66d8424e07650600087b0cfd
😎 Deploy Preview https://deploy-preview-1784--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1064,7 +1064,7 @@ def tweets():
data = get_data(start_from=last_val)
yield data
# change the state to the new value
dlt.current.state()["last_updated"] = data["last_timestamp"]
dlt.current.resource_state()["last_updated"] = data["last_timestamp"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dlt.current.resource_state()["last_updated"] = data["last_timestamp"]
dlt.current.resource_state()["last_updated"] = data["last_timestamp"]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted the extra space

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted the extra space

@dat-a-man dat-a-man changed the title updted the documentation updated the documentation Sep 4, 2024
@AstrakhantsevaAA AstrakhantsevaAA added the documentation Improvements or additions to documentation label Sep 6, 2024
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!!

@AstrakhantsevaAA AstrakhantsevaAA merged commit 301d0a2 into devel Sep 6, 2024
47 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the docs/issue-1783-improve-incremental-docs branch September 6, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve incremental docs to replace deprecated dlt.current.state() function
2 participants