Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added info to troubleshooting #1773

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Added info to troubleshooting #1773

merged 3 commits into from
Oct 22, 2024

Conversation

dat-a-man
Copy link
Collaborator

Description

Added information to the SQL verified source troubleshooting section regarding issues with connecting to MS SQL Server using ConnectorX.

@netlify Netlify
Copy link

netlify bot commented Aug 31, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 9c5a0fd
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/671760a8eb33370008b6bfbb
😎 Deploy Preview https://deploy-preview-1773--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sh-rp sh-rp added the documentation Improvements or additions to documentation label Sep 2, 2024
adrianbr
adrianbr reviewed Sep 2, 2024
View reviewed changes
docs/website/docs/dlt-ecosystem/verified-sources/sql_database.md Outdated
```toml
sources.sql_database.credentials="mssql+pyodbc://loader:loader@localhost/dlt_data?LongAsMax=yes&driver=ODBC+Driver+17+for+SQL+Server"
```

**To fix MS SQL Server connection issues with ConnectorX**:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "Some users have reported issues with MS SQL server and connector x. The issues are outside of dlt and seem to be around how aconnection is created. Here's a user suggested solution (Thanks @user)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markjamesm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dat-a-man will you add this?
"Some users have reported issues with MS SQL Server and Connector X. The problems are not caused by dlt, but by how connections are made. A big thanks to Mark-James M for suggesting a solution."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

AstrakhantsevaAA
AstrakhantsevaAA previously requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dat-a-man will you add this?
"Some users have reported issues with MS SQL Server and Connector X. The problems are not caused by dlt, but by how connections are made. A big thanks to Mark-James M for suggesting a solution."

@rudolfix rudolfix force-pushed the devel branch 2 times, most recently from 2ee3eab to e48f641 Compare September 16, 2024 13:20
@burnash
Copy link
Collaborator

burnash commented Sep 23, 2024

@dat-a-man please resolve conflicts and prepare for merging if this content is still relevant.

@dat-a-man dat-a-man force-pushed the docs/issue-509-add-troubleshooting-tip branch from d83b0a9 to 66846ce Compare October 16, 2024 01:45
@dat-a-man dat-a-man closed this Oct 16, 2024
@dat-a-man dat-a-man force-pushed the docs/issue-509-add-troubleshooting-tip branch from bf375b1 to f290522 Compare October 16, 2024 03:20
@dat-a-man dat-a-man reopened this Oct 16, 2024
@dat-a-man dat-a-man dismissed AstrakhantsevaAA’s stale review October 16, 2024 05:15

Changes made and documentation updated

AstrakhantsevaAA
AstrakhantsevaAA reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to rerun tests

docs/website/docs/dlt-ecosystem/verified-sources/sql_database/troubleshooting.md Show resolved Hide resolved
AstrakhantsevaAA
AstrakhantsevaAA reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rerun tests

docs/website/docs/dlt-ecosystem/verified-sources/sql_database/troubleshooting.md Outdated Show resolved Hide resolved
@AstrakhantsevaAA AstrakhantsevaAA merged commit 058c09f into devel Oct 22, 2024
51 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the docs/issue-509-add-troubleshooting-tip branch October 22, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianbr adrianbr adrianbr left review comments

@AstrakhantsevaAA AstrakhantsevaAA AstrakhantsevaAA approved these changes

Assignees

@hibajamal hibajamal

@dat-a-man dat-a-man

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dat-a-man @burnash @adrianbr @AstrakhantsevaAA @sh-rp @hibajamal