Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link and add env var naming example #1763

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

VioletM
Copy link
Contributor

@VioletM VioletM commented Aug 28, 2024

closes #1752

@VioletM VioletM added the documentation Improvements or additions to documentation label Aug 28, 2024
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 3b67a6c
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66cf4a68fa8ba10007df12a6
😎 Deploy Preview https://deploy-preview-1763--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, only one suggestion

```py
import os

os.environ["PIPELINE_NAME__DESTINATION__DESTINATION_NAME__CREDENTIALS__CREDENTIAL_VALUE"] = "some_value"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would mention in code:

import dlt 

dlt.secrets["<pipeline_name>.destination.<destination name>.credentials"] = "some_value"

@burnash burnash merged commit b1bcf21 into devel Sep 10, 2024
47 checks passed
@burnash burnash deleted the docs/fix_couple_brocken_links branch September 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in documentation: naming conventions
3 participants