Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filesystem): use only netloc and scheme for fingerprint #1516

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

IlyaFaer
Copy link
Contributor

Towards #751

Implements item 1

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 5fe3e67
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6683e62face6010008b4cfb9
😎 Deploy Preview https://deploy-preview-1516--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IlyaFaer IlyaFaer requested a review from rudolfix June 26, 2024 11:27
@IlyaFaer IlyaFaer marked this pull request as ready for review June 26, 2024 11:27
@rudolfix rudolfix added the sprint Marks group of tasks with core team focus at this moment label Jun 26, 2024
@sh-rp
Copy link
Collaborator

sh-rp commented Jul 2, 2024

@IlyaFaer could you update your branch to devel? I think the failing tests should go away then.

@IlyaFaer
Copy link
Contributor Author

IlyaFaer commented Jul 3, 2024

@sh-rp, @rudolfix, yes, it's passing now

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rudolfix rudolfix merged commit eb83406 into devel Jul 4, 2024
52 checks passed
@rudolfix rudolfix deleted the fingerprint_1 branch July 4, 2024 13:09
@rudolfix rudolfix removed the sprint Marks group of tasks with core team focus at this moment label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants