Extend orjson dependency allowed range with excluded versions #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@steinitzu that's right. there were more bugs introduced later and fixed. if we see any problems with |
Closed
rudolfix
added
the
sprint
rudolfix
removed
the
sprint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends the orjson version range to allow
>=3.6.7,<4with some known problematic versions excludedSegafault bug introduced in 3.9.11 seems to be fixed in 3.9.15 ijl/orjson#459 (comment)
Another crashing bug mentioned in changelog introduced in 3.10.1 (and fixed in 3.10.2) so I'm excluding that version too https://github.com/ijl/orjson/blob/7b081e10768a44699f6f7231521b1803c3dfdd87/CHANGELOG.md#fixed
This is within lanchain's range as well:
Related Issues
Additional Context
#1469