Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add page to docs for openapi generator #1417

Merged
merged 6 commits into from
May 27, 2024
Merged

add page to docs for openapi generator #1417

merged 6 commits into from
May 27, 2024

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented May 27, 2024

No description provided.

@sh-rp sh-rp requested review from burnash and AstrakhantsevaAA May 27, 2024 11:47
Copy link

netlify bot commented May 27, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit ed67ad3
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6654a625a6aaa800088dfd8e
😎 Deploy Preview https://deploy-preview-1417--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sh-rp sh-rp marked this pull request as ready for review May 27, 2024 11:50
@sh-rp sh-rp assigned sh-rp and burnash and unassigned sh-rp May 27, 2024
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! just a few comments


## What will be created?

When you run the `init` command above, the following files will be generated:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently we do not run init command

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

└── requirements.txt # the pip requirements for your pipeline
```

> If you re-generate your pipeline, you will be prompted to continue if this folder exists. If you select yes, all generated files will be overwritten. All other files you may have created will remain in this folder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you change it to :::warn :::

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


> If you re-generate your pipeline, you will be prompted to continue if this folder exists. If you select yes, all generated files will be overwritten. All other files you may have created will remain in this folder.

## A closer look at your rest_api dictionary in pokemon/__init__.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformat rest_api as rest_api and pokemon/init.py as pokemon/__init__.py (especially the last one)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I've some small suggestions below

Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sh-rp sh-rp merged commit b94c807 into devel May 27, 2024
41 checks passed
@sh-rp sh-rp deleted the docs/add_generator_page branch May 27, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants