-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add page to docs for openapi generator #1417
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! just a few comments
|
||
## What will be created? | ||
|
||
When you run the `init` command above, the following files will be generated: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently we do not run init
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
└── requirements.txt # the pip requirements for your pipeline | ||
``` | ||
|
||
> If you re-generate your pipeline, you will be prompted to continue if this folder exists. If you select yes, all generated files will be overwritten. All other files you may have created will remain in this folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you change it to :::warn :::
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
||
> If you re-generate your pipeline, you will be prompted to continue if this folder exists. If you select yes, all generated files will be overwritten. All other files you may have created will remain in this folder. | ||
|
||
## A closer look at your rest_api dictionary in pokemon/__init__.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reformat rest_api as rest_api
and pokemon/init.py as pokemon/__init__.py
(especially the last one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I've some small suggestions below
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/openapi-generator.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
No description provided.