-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend layout placeholder params for filesystem destinations #1182
Conversation
✅ Deploy Preview for dlt-hub-docs canceled.
|
8d86605
to
ad9bba4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code got a little messy. let's review it together
44cfe5e
to
ba83add
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! a few comments and let's deal with the replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR addresses #930
Requirements:
@sh-rp recommends to test with staging destination
you’ll have to test it, write a test where you run the destination settings that use staging and add a map function for the filename
Newly introduced placeholders
TODO