Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTClient: add support for relative next URLs in LinkPaginators #1163

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented Mar 31, 2024

Description

This pull request:

  • introduces handling of relative next URLs in classes derived from BaseNextUrlPaginator.
  • improves mock_api_server()

Related PRs

@burnash burnash requested a review from rudolfix March 31, 2024 11:39
Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit b080d34
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66094b79c93a1e0008baf94e
😎 Deploy Preview https://deploy-preview-1163--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@burnash burnash requested a review from VioletM March 31, 2024 11:40
Copy link
Contributor

@VioletM VioletM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As I said it also could be a case

{
                "next_reference": "/api/resource?page=2&size=100",
            }

But I guessed it could be handled separately or not handled at all

@burnash burnash merged commit ecb5aa0 into devel Apr 2, 2024
47 of 53 checks passed
@burnash burnash deleted the enh/relative_urls_in_pagination branch April 2, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants