Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs component with onboarding call #1139

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add docs component with onboarding call #1139

merged 1 commit into from
Mar 26, 2024

Conversation

VioletM
Copy link
Contributor

@VioletM VioletM commented Mar 23, 2024

Update the onboarding link

@VioletM VioletM requested a review from burnash March 23, 2024 21:41
@VioletM VioletM self-assigned this Mar 23, 2024
Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit fafd57c
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65ff4c829874be0008f02b79
😎 Deploy Preview https://deploy-preview-1139--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sh-rp
Copy link
Collaborator

sh-rp commented Mar 25, 2024

@VioletM we have this docs preprocessor now which enables us to inject stuff into doc pages on compile time. If there are certain patterns for when and where these headers get added, we can also do it in this step to keep marketing stuff out of the GitHub docs. I'm not sure if we need to do this, but maybe you can keep that in mind.

@VioletM
Copy link
Contributor Author

VioletM commented Mar 25, 2024

@sh-rp

For me, it is more or less the same because any change will go through PR anyway (or am I wrong?), I mostly care, that it's one change instead of 20. If the dev team thinks separation is needed, let's put it to the docs preprocessing.

Currently, the pattern where headers get added -- at the beginning of each source and at the central destination page.

@sh-rp sh-rp merged commit 359721a into devel Mar 26, 2024
44 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the change_onboarding branch March 26, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants