Docs: Simpler Examples, generate examples pages from actual examples code #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
# Conflicts: # docs/examples/connector_x_arrow/load_arrow.py # docs/examples/custom_destination_bigquery/custom_destination_bigquery.py # docs/examples/google_sheets/google_sheets.py # docs/examples/incremental_loading/incremental_loading.py # docs/examples/pdf_to_weaviate/pdf_to_weaviate.py # docs/examples/transformers/transformers.py
make examples raise in case of failed loads
sh-rp
commented
Apr 3, 2024
| @@ -0,0 +1,72 @@ | |||
| """ | |||
AstrakhantsevaAA
previously approved these changes
Apr 3, 2024
| - How to get arrow tables from [connector X](https://github.com/sfu-db/connector-x) and yield them. | ||
| - That merge and incremental loads work with arrow tables. | ||
| - How to enable [incremental loading](../general-usage/incremental-loading) for efficient data extraction. | ||
| - How to use build in ConnectionString credentials. |
There was a problem hiding this comment.
so we don't have Setup: Running this example on your machine section anymore?
do you think it's useless or it difficult to add in this implementation?
There was a problem hiding this comment.
it was a feedback from @burnash (at least if i recall correctly) to make these pages more concise. I can add this section back in though, i am not super opinionated on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we fully deduplicate the examples. We generate the examples pages in the docs based on the code in the docs/examples folder, not vice versa.
TODO: