custom destination fixes #1119
Merged
custom destination fixes #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
rename config spec format generic destination example
remove some unneded things from the destination tests
|
I think 3. is already done. |
fix tests for source decorator
sh-rp
reviewed
Mar 20, 2024
sh-rp
reviewed
Mar 20, 2024
| @@ -437,6 +451,54 @@ def my_gcp_sink( | |||
| ) | |||
|
|
|||
|
|
|||
| def test_destination_with_spec() -> None: | |||
There was a problem hiding this comment.
lmk if this is enough wrt to testing the custom base
There was a problem hiding this comment.
improved a little bit. spec is not a custom base. it is THE spec that will be used
rudolfix
commented
Mar 21, 2024
| @@ -437,6 +451,54 @@ def my_gcp_sink( | |||
| ) | |||
|
|
|||
|
|
|||
| def test_destination_with_spec() -> None: | |||
There was a problem hiding this comment.
improved a little bit. spec is not a custom base. it is THE spec that will be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see commit list
@sh-rp you can take over this: