Docs: Document incremental definition via config.toml #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sultaniman
reviewed
Mar 20, 2024
|
|
||
|
|
||
| pipeline = dlt.pipeline( | ||
| pipeline_name="incs", |
There was a problem hiding this comment.
I think we should name pipeline properly here something like pipeline_with_incremental
| 1. The `id_after` parameter is defined as an incremental source, and its value is retrieved from the configuration using `dlt.config.value`. | ||
| ```py | ||
| @dlt.resource(table_name="incs") | ||
| def inc_res(id_after: dlt.sources.incremental = dlt.config.value): |
There was a problem hiding this comment.
Also here we maybe need to change the table_name parameter and then name of the function to something meaningful.
There was a problem hiding this comment.
also function name please :)
sultaniman
reviewed
Mar 21, 2024
|
|
||
| pipeline.run(inc_res) | ||
| ``` | ||
| The `inc_res` function generates a range of data, each item being a dictionary with keys `id`, `idAfter`, and `name`. The `idAfter` key is used by the incremental resource to track progress. |
There was a problem hiding this comment.
And in the text as well
|
@burnash @AstrakhantsevaAA how can we improve wording? |
|
@sultaniman added more context. Please see if it's okay. |
AstrakhantsevaAA
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading incremental parameters from configuration files.
Description
Related Issues
Additional Context