Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the proposed segment migration blog #1073

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Adding the proposed segment migration blog #1073

merged 3 commits into from
Mar 11, 2024

Conversation

zem360
Copy link
Contributor

@zem360 zem360 commented Mar 11, 2024

Adding the segment migration blog.

@zem360 zem360 requested a review from adrianbr March 11, 2024 08:45
@netlify Netlify
Copy link

netlify bot commented Mar 11, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit d749bf0
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65eec7bca79f940008219640
😎 Deploy Preview https://deploy-preview-1073--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zem360 zem360 requested a review from AstrakhantsevaAA March 11, 2024 09:44
AstrakhantsevaAA
AstrakhantsevaAA approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Amazing work Zaeem!
one small moment (probably for future): usually we lowercase dlt and write it as code dlt.

@zem360 zem360 merged commit 493f44a into master Mar 11, 2024
44 checks passed
@zem360 zem360 deleted the blog/segment_migration branch March 11, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstrakhantsevaAA AstrakhantsevaAA AstrakhantsevaAA approved these changes

@adrianbr adrianbr Awaiting requested review from adrianbr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zem360 @AstrakhantsevaAA