Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Updated Config providers docs #1071

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

dat-a-man
Copy link
Collaborator

Description

Documentation update

Related Issues

  • Fixes #...
  • Closes #...
  • Resolves #...

Additional Context

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 0b3ee8f
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/660164f7512f8800080658a2
😎 Deploy Preview https://deploy-preview-1071--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

```


1. When `dlt` evaluates a request like 'dlt.secrets["my_section.gcp_credentials"]', it looks for it as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace this sentence with this please:
When dlt evaluates the request dlt.secrets["my_section.gcp_credentials"] it must find the private_key for Google credentials. It looks for it as follows:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fragments of code should be highlighted as code
dlt.secrets[“my_section.gcp_credentials”] -> dlt.secrets["my_section.gcp_credentials"]

@dat-a-man
Copy link
Collaborator Author

yeah, done.

Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private_key should be as code too

@sh-rp sh-rp assigned sh-rp, dat-a-man and AstrakhantsevaAA and unassigned sh-rp and dat-a-man Mar 18, 2024
@AstrakhantsevaAA AstrakhantsevaAA merged commit 01e528e into master Mar 25, 2024
44 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the docs/config_providers_update branch March 25, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants