-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended filesystem layout placeholders for destinations #930
Labels
destination
Issue related to new destinations
enhancement
New feature or request
support
This issue is monitored by Solution Engineer
Comments
@Pipboyguy this and #759 are related. This is our best scope description: #555 (comment) My take here
|
Pipboyguy
added
destination
Issue related to new destinations
enhancement
New feature or request
community
This issue came from slack community workspace
labels
Feb 26, 2024
This was referenced Feb 26, 2024
Pipboyguy
added a commit
that referenced
this issue
Feb 26, 2024
Signed-off-by: Marcel Coetzee <[email protected]>
Pipboyguy
added a commit
that referenced
this issue
Mar 3, 2024
Signed-off-by: Marcel Coetzee <[email protected]>
9 tasks
rudolfix
added
support
This issue is monitored by Solution Engineer
and removed
community
This issue came from slack community workspace
labels
Apr 2, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
destination
Issue related to new destinations
enhancement
New feature or request
support
This issue is monitored by Solution Engineer
Problem statement
There are already few requests to extend the supported variable placeholders for
layout
option, which has the following default valueThere are already couple of requests on GitHub 1, 2 and slack. This means users would love to have more fine grained control for layout formatting options using more placeholders.
Request #1
Request #2
Request #3
TODO
We need to augment LoadFilesystemJob.make_destination_filename and expand the the available parameters with datetime fields for
year, month, day, hour, minute, second, microsecond
Extending
[SUPPORTED_PLACEHOLDERS](https://github.com/dlt-hub/dlt/blob/devel/dlt/destinations/path_utils.py#L10)
with known set of variables should suffice the minimum use case needs currently it has the following valuesSUPPORTED_PLACEHOLDERS = {"schema_name", "table_name", "load_id", "file_id", "ext", "curr_date"}
After the extension this will look like
SUPPORTED_PLACEHOLDERS = {"schema_name", "table_name", "load_id", "file_id", "ext", "curr_date", "year", "month", "day", "hour", "minute", "second", "microsecond"}
The text was updated successfully, but these errors were encountered: