Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt_utils.py references logbook which is no longer used in dbt-core #2151

Closed
cmdkeen opened this issue Dec 16, 2024 · 0 comments · Fixed by #2175
Closed

dbt_utils.py references logbook which is no longer used in dbt-core #2151

cmdkeen opened this issue Dec 16, 2024 · 0 comments · Fixed by #2175
Assignees
Labels
bug Something isn't working

Comments

@cmdkeen
Copy link

cmdkeen commented Dec 16, 2024

dlt version

1.4.1

Describe the problem

The logbook package was removed from dbt-core but is still referenced in

import logbook.compat
leading to errors when using dlt to run dbt.

dlt.common.exceptions.MissingDependencyException:
You must install additional dependencies to run DBT Core. If you use pip you may do the following:

pip install "dbt-core"

Expected behavior

No response

Steps to reproduce

dbt-core 1.8.6

    dbt = dlt.dbt.package(
        pipeline,
        "./dbt",
    )

    models = dbt.run_all()

Operating system

Linux

Runtime environment

Local

Python version

3.10

dlt data source

No response

dlt destination

Snowflake

Other deployment details

No response

Additional information

Suggest removing the references to logbook from dbt_utils.py

@rudolfix rudolfix added the bug Something isn't working label Dec 19, 2024
@rudolfix rudolfix moved this from Todo to In Progress in dlt core library Dec 19, 2024
@rudolfix rudolfix self-assigned this Dec 19, 2024
rudolfix added a commit that referenced this issue Dec 23, 2024
* fix links (#1977)

* correctly converts dict arrow types into dlt types

* drops dbt compat code for versions below 1.5

* ignores encoding errors when reading from process pipe

---------

Co-authored-by: adrianbr <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in dlt core library Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants