Skip to content

Commit

Permalink
fix post devel merge linting errors
Browse files Browse the repository at this point in the history
  • Loading branch information
sh-rp committed Mar 27, 2024
1 parent 6483e0c commit e1868ae
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 18 deletions.
19 changes: 2 additions & 17 deletions dlt/destinations/impl/dremio/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,27 +32,12 @@ def db_kwargs(self) -> Dict[str, Any]:
@configspec
class DremioClientConfiguration(DestinationClientDwhWithStagingConfiguration):
destination_type: Final[str] = "dremio" # type: ignore[misc]
credentials: DremioCredentials
staging_data_source: str
credentials: DremioCredentials = None
staging_data_source: str = None
"""The name of the staging data source"""

def fingerprint(self) -> str:
"""Returns a fingerprint of host part of a connection string"""
if self.credentials and self.credentials.host:
return digest128(self.credentials.host)
return ""

if TYPE_CHECKING:

def __init__(
self,
*,
destination_type: str = None,
credentials: DremioCredentials = None,
staging_data_source: str = None,
dataset_name: str = None,
default_schema_name: Optional[str] = None,
staging_config: Optional[DestinationClientStagingConfiguration] = None,
destination_name: str = None,
environment: str = None,
) -> None: ...
2 changes: 1 addition & 1 deletion tests/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@

# filter out active destinations for current tests
ACTIVE_DESTINATIONS = set(dlt.config.get("ACTIVE_DESTINATIONS", list) or IMPLEMENTED_DESTINATIONS)

ACTIVE_DESTINATIONS = {"dremio"}
ACTIVE_SQL_DESTINATIONS = SQL_DESTINATIONS.intersection(ACTIVE_DESTINATIONS)
ACTIVE_NON_SQL_DESTINATIONS = NON_SQL_DESTINATIONS.intersection(ACTIVE_DESTINATIONS)

Expand Down

0 comments on commit e1868ae

Please sign in to comment.